Add support for chunking; use clap for arg parsing #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the cargo subcommand thing as well. |
|
@Manishearth @robertbastian I have limited capacity the next few weeks. I gave you both permissions for this repo and crates.io, so feel free to merge and publish whatever! |
|
Oh, thank you very much! I'll wait for proper review from @robertbastian or someone else and then merge. |
This was referenced Jul 27, 2023
|
lgtm but would like this to build |
|
yeah it's being CId with deny(clippy) |
|
Published as 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
I haven't yet tested this in our CI, but we're getting to the point where c-a-f for all of ICU4X hits runner size limits since we can't clean it up partway through. Chunking seems like a good path forward, and the task already takes too long. We may also want to use the
max_combination_sizeparameter more, but this seems useful either way.This currently chunks packages, not feature-sets. We could do the latter; it's a little bit more involved, but I do think packages is a fine way to implement this.